Aryeh Gregor [Mon, 8 Oct 2018 13:30:13 +0000 (16:30 +0300)]
Improve ApiLogin test coverage
Coverage is 100% except for one session-related bit that seems a bit
involved to test right now. It looks like it will be easier once
SessionManager becomes a service.
I removed the third parameter from the return value of
canonicalizeLoginData, since
af37a4c7 made it always return true.
I also removed three lines of dead code from ApiLogin.php.
Change-Id: Ia0073eddd27c82827518e0031e3c313f83cfd7cc
Aryeh Gregor [Mon, 8 Oct 2018 11:29:47 +0000 (14:29 +0300)]
Clean up ApiLoginTest
Change-Id: Icd77f8a5ee0c26cfbd3cc8f220412cfa1bf49d60
Translation updater bot [Sun, 7 Oct 2018 19:55:00 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I37d7b1dfa4bbe393b32d62f8f8ac564ebb24d149
Translation updater bot [Sat, 6 Oct 2018 19:54:18 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ib87a638392b5f4d20ce69a0af2895692f11197d4
jhsoby [Mon, 27 Aug 2018 21:53:46 +0000 (23:53 +0200)]
Fix numerals for Saraiki
Change numerals from Persian numerals to
Eastern Arabic numerals.
Bug: T202943
Change-Id: I9ef7c18d40b9aa3f1c3b3db7407d3f61feb7fd1d
jenkins-bot [Sat, 6 Oct 2018 03:21:47 +0000 (03:21 +0000)]
Merge "messagecache: use MergeableUpdate for the deferred replace() update"
jenkins-bot [Sat, 6 Oct 2018 00:09:41 +0000 (00:09 +0000)]
Merge "Add link to protect log to action=info"
jenkins-bot [Fri, 5 Oct 2018 23:26:26 +0000 (23:26 +0000)]
Merge "Remove trailing spaces from IP addr in Special:DeletedContributions"
Alex Ezell [Fri, 5 Oct 2018 21:32:00 +0000 (17:32 -0400)]
Replace Media namespace redirects with File namespace
If a user creates a redirect that goes to a [[Media:example.jpg]]
page, then an exception is thrown because NS_MEDIA is a virtual
namespace. This change catches this case and changes the namespace
to an NS_FILE namespace and the redirect works correctly. This
change only happens when we are dealing with a redirect so other
uses of the NS_MEDIA namespace shouldn't be affected.
Bug: T203942
Change-Id: Ia744059650e16510732a65d51b138b11cbd43eb4
Aaron Schulz [Thu, 4 Oct 2018 20:14:32 +0000 (13:14 -0700)]
messagecache: use MergeableUpdate for the deferred replace() update
This combines the load loop for multiple messages for a language code.
Bug: T203925
Bug: T193271
Change-Id: Ie5e1e83d6740344b7ca641c99fb3bd4ad5718492
Translation updater bot [Fri, 5 Oct 2018 19:56:02 +0000 (21:56 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I16181fad87c2d0afe3c43188c9f7807b6a953698
jenkins-bot [Fri, 5 Oct 2018 19:29:40 +0000 (19:29 +0000)]
Merge "UIDGenerator: Remove the clock skew problem"
jenkins-bot [Fri, 5 Oct 2018 19:28:48 +0000 (19:28 +0000)]
Merge "Write Latin and other scripts with captial letter"
jenkins-bot [Fri, 5 Oct 2018 19:03:26 +0000 (19:03 +0000)]
Merge "search: Fix DYM typos in widget"
Fomafix [Fri, 5 Oct 2018 16:37:53 +0000 (18:37 +0200)]
Write Latin and other scripts with captial letter
Change-Id: I16c660e54191b63cd6eb3407cb00504665930c4e
Alangi Derick [Fri, 5 Oct 2018 14:22:15 +0000 (15:22 +0100)]
Remove trailing spaces from IP addr in Special:DeletedContributions
* Trim "target" to remove trailing spaces from IP address in
Special:DeletedContributions that triggers MW internal error.
Bug: T187619
Change-Id: Ic6b0d8020553ecce4dcf97f9c78487d3174444d8
jenkins-bot [Fri, 5 Oct 2018 08:04:08 +0000 (08:04 +0000)]
Merge "wdio-mediawiki: Add 'fragment' parameter to Page"
jenkins-bot [Fri, 5 Oct 2018 06:59:36 +0000 (06:59 +0000)]
Merge "Localisation updates from https://translatewiki.net."
jenkins-bot [Fri, 5 Oct 2018 00:43:56 +0000 (00:43 +0000)]
Merge "Test ApiUnblock"
jenkins-bot [Fri, 5 Oct 2018 00:29:50 +0000 (00:29 +0000)]
Merge "Fix List* in MessagesKo.php"
Aryeh Gregor [Thu, 4 Oct 2018 12:57:10 +0000 (15:57 +0300)]
Test ApiUnblock
Full coverage (except for the examples/help URL).
Change-Id: I4c618506b5446680f06fa9b605d3babe7194de94
jenkins-bot [Thu, 4 Oct 2018 23:22:13 +0000 (23:22 +0000)]
Merge "filebackend: Add normalization for stat errors"
Timo Tijhof [Thu, 4 Oct 2018 18:54:36 +0000 (19:54 +0100)]
filebackend: Add normalization for stat errors
Bug: T205567
Change-Id: I75f1eb6dc2cbff0ea0dc0706cca0ad79c54fc612
jenkins-bot [Thu, 4 Oct 2018 21:37:00 +0000 (21:37 +0000)]
Merge "Enforce no-session constraint in opensearch_desc.php and profileinfo.php"
Translation updater bot [Thu, 4 Oct 2018 20:03:30 +0000 (22:03 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Idf339b32a190b7a770c0465e4545948861ab979d
jenkins-bot [Thu, 4 Oct 2018 19:53:45 +0000 (19:53 +0000)]
Merge "Clean up UIDGenerator field comments"
Timo Tijhof [Thu, 4 Oct 2018 00:38:45 +0000 (01:38 +0100)]
UIDGenerator: Remove the clock skew problem
In a nutshell:
This commmit removes the use of drifting microtime()
in favour of non-drifting time(). Then, we increase the size of
the counter by x1000, and consider every 1000 increments as 1ms
for the purposes of UUID.
Why:
This means we eliminate the whole code that can produce a fatal
exception when the clock drifts by more than we can wait for,
which puts us in a logical conundrum we can't get out of, hence
it previously fatalled.
Not aborting random end-user requests and jobs is good.
This also means we avoid the vast majority of cases where
MediaWiki would busy-loop for upto 10ms in a likely-to-fail
attempt to sync the clock. This means the method runs faster,
which is a nice win, albeit not the main objective.
Bug: T94522
Change-Id: Ia8a847078ec76d633854db6823a20f0961c80f80
Martin Urbanec [Sat, 29 Sep 2018 17:03:12 +0000 (19:03 +0200)]
Add link to protect log to action=info
Bug: T52190
Change-Id: Id983d4585a253ebe34e07f07472548f6d1d20bce
jenkins-bot [Thu, 4 Oct 2018 18:31:32 +0000 (18:31 +0000)]
Merge "Update OOUI to v0.29.1"
jenkins-bot [Thu, 4 Oct 2018 18:11:58 +0000 (18:11 +0000)]
Merge "Avoid fatal when finding no base revision for a null revision."
daniel [Thu, 4 Oct 2018 10:49:50 +0000 (12:49 +0200)]
Avoid fatal when finding no base revision for a null revision.
Bug: T205675
Change-Id: Iae67649a1be9597086033ad34d9d00556ba35730
James D. Forrester [Thu, 4 Oct 2018 17:12:39 +0000 (10:12 -0700)]
Update OOUI to v0.29.1
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.29.1
Local fix to rcfilters for renamed parent method.
Bug: T130434
Bug: T165650
Bug: T183299
Bug: T196756
Bug: T205472
Bug: T205692
Bug: T205979
Bug: T206153
Bug: T206155
Depends-On: Ie847465af6762fd0322a5be4adf601cabda2d458
Change-Id: I704e3197e86d484be3ab91b9282d6ac1b7db2251
jenkins-bot [Thu, 4 Oct 2018 16:58:00 +0000 (16:58 +0000)]
Merge "ParserOutput::getCacheTime should stay the same after the first call."
jenkins-bot [Thu, 4 Oct 2018 16:53:20 +0000 (16:53 +0000)]
Merge "Ensure OutputPageTest works when Translate extension is loaded"
jenkins-bot [Thu, 4 Oct 2018 16:38:46 +0000 (16:38 +0000)]
Merge "Use Remex for TextContentTest subclasses"
jenkins-bot [Thu, 4 Oct 2018 16:20:25 +0000 (16:20 +0000)]
Merge "Disallow overriding services that were set"
jenkins-bot [Thu, 4 Oct 2018 15:54:57 +0000 (15:54 +0000)]
Merge "tests: Allow string to be passed to getTestUser() etc."
jenkins-bot [Thu, 4 Oct 2018 15:50:51 +0000 (15:50 +0000)]
Merge "Minor cleanup in ApiBlockTest"
jenkins-bot [Thu, 4 Oct 2018 15:43:12 +0000 (15:43 +0000)]
Merge "Only use "*Test.php" for actual PHPUnit tests"
jenkins-bot [Thu, 4 Oct 2018 15:40:48 +0000 (15:40 +0000)]
Merge "Re-enable tests from TitlePermissionTest"
jenkins-bot [Thu, 4 Oct 2018 15:38:58 +0000 (15:38 +0000)]
Merge "registration: Let extensions add PHP extension requirements"
Erik Bernhardson [Thu, 4 Oct 2018 14:44:09 +0000 (07:44 -0700)]
search: Fix DYM typos in widget
* DYM link was triggering the 'go' feature due to fulltext misspelled
* all ids are of the form mw-search-*, except one. Make it the same
(WikimediaEvents code was expecting everything to be mw-search-*)
Bug: T206232
Change-Id: Ib91ccf28879b8af2a8c0f2a40b9fe3ec4259a730
Aryeh Gregor [Thu, 4 Oct 2018 12:56:41 +0000 (15:56 +0300)]
tests: Allow string to be passed to getTestUser() etc.
If there's only one group, let's not require the brackets.
Change-Id: Ib46ef1facbbbf2ba01c13b8290ebbe3a8e08cb4f
Aryeh Gregor [Thu, 4 Oct 2018 12:55:55 +0000 (15:55 +0300)]
Minor cleanup in ApiBlockTest
Use tablesUsed instead of cleaning up ourselves.
Change-Id: Ibe470a8f292d65ceeaa098d5c033b8585501a9f3
Translation updater bot [Thu, 4 Oct 2018 12:12:04 +0000 (14:12 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I3a709a2ec2f0e13ca2b8015aa9de36e9e7d4e063
daniel [Thu, 4 Oct 2018 10:32:06 +0000 (12:32 +0200)]
ParserOutput::getCacheTime should stay the same after the first call.
Previously, getCacheTime would default to the current time, potentially
causing the return value to change over subsequent calls. With this change,
the value is determined on the first call, and then remembered for subsequent
calls.
Bug: T205464
Change-Id: If240161c71d523ad5b0d33b9378950e0bebceb6e
Timo Tijhof [Wed, 3 Oct 2018 23:49:53 +0000 (00:49 +0100)]
UIDGenerator: Misc clean up
Various miscellaneous clean ups with no change to any of the
logical code. This to make the next commit have a cleaner diff
for easier review.
* Make internal millitime() non-static.
* Improve documentation and add missing @covers annotations.
* Correct getTimestampedID88() documentation to state that
only two values need to be passed, not three.
This is significant because the Flow extension is actually
using this method in a subclass and passes only two values.
Bug: T94522
Change-Id: I2a0c51bea58df4cc0c253c1c10de3ac383f04c8e
WMDE-Fisch [Mon, 1 Oct 2018 14:29:56 +0000 (16:29 +0200)]
wdio-mediawiki: Add 'fragment' parameter to Page
In some cases it's useful adding a fragment to the url, e.g. when
accessing the beta features preference page. This patch adds support
for that on the Page object.
Change-Id: I4b6aa5e7e89e60f05e217fc557bf6786441855e6
Aaron Schulz [Thu, 4 Oct 2018 08:11:26 +0000 (01:11 -0700)]
Clean up UIDGenerator field comments
Change-Id: I0c6d125ec03a56fe0b3456cff7d498d231315e0d
Fomafix [Thu, 4 Oct 2018 07:06:00 +0000 (09:06 +0200)]
Phabricator: Use Tddddd instead of Bug ddddd in comments
Change-Id: Ic9fe03cab270bd6be738af346164ad5d31a0d780
jenkins-bot [Thu, 4 Oct 2018 02:46:25 +0000 (02:46 +0000)]
Merge "rdbms: clarfiy some comments about commitMasterChanges() methods"
jenkins-bot [Thu, 4 Oct 2018 02:46:19 +0000 (02:46 +0000)]
Merge "rdbms: clarify IDatabase::setTransactionListener() comment"
jenkins-bot [Thu, 4 Oct 2018 02:43:09 +0000 (02:43 +0000)]
Merge "MessageCache: do not store the EXCESSIVE array as it is only needed for HASH"
Aaron Schulz [Wed, 3 Oct 2018 22:39:55 +0000 (15:39 -0700)]
rdbms: clarfiy some comments about commitMasterChanges() methods
Change-Id: I2c9f3cb9b4dcd16f561e55d119849b526e9d402b
Aaron Schulz [Wed, 3 Oct 2018 19:38:46 +0000 (12:38 -0700)]
MessageCache: do not store the EXCESSIVE array as it is only needed for HASH
This saves space as the number of entries becomes larger.
Bug: T193271
Change-Id: I32d7512d7f05ae7c9a69b88cd19df64d7a21b4a1
jenkins-bot [Thu, 4 Oct 2018 01:29:14 +0000 (01:29 +0000)]
Merge "Fix option name in maintenance/importDump.php"
James D. Forrester [Wed, 26 Sep 2018 23:12:23 +0000 (16:12 -0700)]
Special:Preferences: Drop isOouiEnabled() before it gets released
Depends-On: Ic1df4e965df61c2d164b2ffd2fa07ed68b028ddf
Depends-On: If0e83751089d010d026a736040d77b9a0851ef42
Depends-On: Id9c840e979b723806883bb3e63d7f2f691fea629
Depends-On: I9d5dbf449c624233cef2ccf0e3e4200d9eb2b7c3
Change-Id: If2a21a6a40802ab187b30de78fb521f016dd10cd
jenkins-bot [Wed, 3 Oct 2018 23:57:26 +0000 (23:57 +0000)]
Merge "Special:Preferences: Drop non-OOUI legacy form version"
jenkins-bot [Wed, 3 Oct 2018 23:32:36 +0000 (23:32 +0000)]
Merge "Drop 'SpecialRecentChangesQuery' & 'SpecialWatchlistQuery' hooks, deprecated in 1.23"
jenkins-bot [Wed, 3 Oct 2018 23:25:22 +0000 (23:25 +0000)]
Merge "Database: close() should not commit transactions"
Aaron Schulz [Wed, 3 Oct 2018 22:01:29 +0000 (18:01 -0400)]
Make UID clock drift error have more details.
Change-Id: Ic682e48b06161c2a286f5da9016f4831ee72a31e
Kosta Harlan [Wed, 3 Oct 2018 20:42:55 +0000 (16:42 -0400)]
Move test assertion to mirror parameter order
Follow up from I2df0551c5837adc578b27082ab6ba2ac95d937f8
Bug: T206130
Change-Id: Ib669c77fdb709846d0182cb28796cf53914114c4
jenkins-bot [Wed, 3 Oct 2018 19:50:32 +0000 (19:50 +0000)]
Merge "SECURITY: Fix permissions check for patrol action"
Brad Jorsch [Wed, 3 Oct 2018 19:07:24 +0000 (15:07 -0400)]
Enforce no-session constraint in opensearch_desc.php and profileinfo.php
Attempts to use session data via these endpoints will now cause
exceptions to be thrown.
Bug: T127233
Change-Id: I28b080a84e7b928e4336a5a1ec770bb57b05d009
Kosta Harlan [Wed, 3 Oct 2018 16:47:14 +0000 (12:47 -0400)]
SECURITY: Fix permissions check for patrol action
Return existing errors instead of empty array in checkUserConfigPermissions().
Returning an empty array wiped out previously-found errors.
Also add test coverage for patrol action.
Bug: T206130
Change-Id: I2df0551c5837adc578b27082ab6ba2ac95d937f8
Brad Jorsch [Wed, 3 Oct 2018 17:38:19 +0000 (13:38 -0400)]
Database: close() should not commit transactions
Transactional databases normally roll back when a connection is closed
with an open transaction rather than committing them, so MediaWiki
committing them is unexpected.
There are two cases being changed here: automatic transactions without
writes and manual transactions. For the former it shouldn't make a
difference if we commit or roll back since no writes were done anyway.
The latter has logged a message since MW 1.31 (I0992f9a8), and that
warning has not been logged in Wikimedia production in the past 60 days
so we should be ok there too.
Bug: T206147
Change-Id: Ieceef4deb49044db8f0622d38ee76c9d9f39704c
Brad Jorsch [Mon, 23 Jul 2018 16:06:20 +0000 (12:06 -0400)]
Fix option name in maintenance/importDump.php
Bug: T200138
Change-Id: Icc5d9878bc3ebdf03efec9161b220ad0bf55dc9a
jenkins-bot [Wed, 3 Oct 2018 18:04:15 +0000 (18:04 +0000)]
Merge "Show copyright based on $output->hasCopyright()"
jenkins-bot [Wed, 3 Oct 2018 18:01:30 +0000 (18:01 +0000)]
Merge "Remove unused function: isStructuredFilterUiEnabledByDefault"
Aryeh Gregor [Thu, 9 Aug 2018 14:38:13 +0000 (17:38 +0300)]
Only use "*Test.php" for actual PHPUnit tests
Otherwise I get errors every time I try to run PHPUnit on includes/ or
includes/parser, because it tries to run ParserIntegrationTest.php and
fails. Apparently the <exclude> in suite.xml doesn't work if PHPUnit is
invoked on a directory.
Bug: T201278
Change-Id: I7d09576bee2705d8516152e8fa671da8dac40233
Stephane Bisson [Wed, 3 Oct 2018 13:12:37 +0000 (09:12 -0400)]
Show copyright based on $output->hasCopyright()
Introducing setCopyright/hasCopyright in OutputPage to
make the showing of the copyright message controllable
by pages other than articles.
hasCopyright defaults to isArticle() to preserve the rule
that all article should show the copyright.
This is used by Flow to show the copyright
on various pages that contain user-generated
content.
Bug: T184960
Change-Id: I3a50dbcedc6b119b9262c50cb3a84b0dd230fb3d
Translation updater bot [Wed, 3 Oct 2018 15:20:20 +0000 (17:20 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ic0af665f26aa1af0bd706ee26bb811d0a482ec2b
Aryeh Gregor [Wed, 3 Oct 2018 12:37:12 +0000 (15:37 +0300)]
Re-enable tests from TitlePermissionTest
Let's see if they work now that services are reset between tests.
This reverts commit
7f843b0c0472b9da909d7abf7c2829eec17a5b3e.
Bug: T201776
Change-Id: Iea7c74f8c77a97d83385b4399e500cf8129a1158
Yongmin Hong [Wed, 3 Oct 2018 11:38:54 +0000 (20:38 +0900)]
Fix List* in MessagesKo.php
The primary one does not state it is "list". Fixes that where that
is a primarily a list.
Change-Id: I56374841b972be71d25ffa10b5dc33cc3ea3b140
Signed-off-by: Yongmin Hong <revi@pobox.com>
Fomafix [Sat, 7 Jul 2018 09:53:04 +0000 (11:53 +0200)]
Deprecate Language::setCode as public method
setCode changes the language code for the Language object but it also
replaces the whole language codes for all Language objects.
> $lang = Language::factory( 'fr' )
> $lang2 = Language::factory( 'fr' )
> $lang->setCode( 'it' )
> print $lang2->getCode()
it
> $lang3 = Language::factory( 'fr' )
> print $lang3->getCode()
it
Better assign a new Language object.
Also add more tests for Language::equals.
Depends-On: I61439bac82021344c3f9a6056cccd937b3450af2
Depends-On: I2d9e551d6eb33f28f42aeaf48160eba21b83881f
Change-Id: I201b479f58e63c9c40fb8a3ec9575a551fb35235
jenkins-bot [Wed, 3 Oct 2018 06:42:17 +0000 (06:42 +0000)]
Merge "API: Handle empty xxnamespace parameter in ApiQueryBacklinksprop"
jenkins-bot [Wed, 3 Oct 2018 06:41:03 +0000 (06:41 +0000)]
Merge "AutoloadGenerator: Filter PSR4-compliant classes instead of ignoring directories"
jenkins-bot [Wed, 3 Oct 2018 01:23:54 +0000 (01:23 +0000)]
Merge "Migrate image descriptions from image_comment_temp"
jenkins-bot [Wed, 3 Oct 2018 00:43:17 +0000 (00:43 +0000)]
Merge "RCFilters: better vertical alignment of checkbox and text in menus"
Stephane Bisson [Tue, 2 Oct 2018 16:55:12 +0000 (12:55 -0400)]
RCFilters: better vertical alignment of checkbox and text in menus
- Remove min-height so menu items are a little smaller and
their content is vertically-aligned.
- Force `vertical-align: middle;` for checkboxes by overriding
OOUI with extreme specificity.
Bug: T200364
Change-Id: If0b2b5c1b749f913badbd0c02a85852ec0007020
jenkins-bot [Tue, 2 Oct 2018 23:51:03 +0000 (23:51 +0000)]
Merge "MessageCache: remove confusing and unused $isFullKey parameter from get()"
Aaron Schulz [Tue, 2 Oct 2018 20:53:32 +0000 (13:53 -0700)]
MessageCache: remove confusing and unused $isFullKey parameter from get()
Follows-up
cba0fb1c1576324e87b27, which removed the last caller.
Change-Id: I00c17fedff39b1b35519cff2a0f8eac3e4d6f2ab
Brad Jorsch [Tue, 2 Oct 2018 21:18:38 +0000 (17:18 -0400)]
Language: Don't return aliases to namespaces that don't exist
On a multi-wiki server using a l10n cache, the cache will probably
include aliases from all extensions enabled for any wiki while the
namespaces themselves will only be defined on the wikis where the
extension is loaded.
Bug: T206030
Change-Id: I985dfa3eb17944d5fc0c5be0979be21504fb1341
jenkins-bot [Tue, 2 Oct 2018 16:44:54 +0000 (16:44 +0000)]
Merge "rdbms: make * consistently act like in select/insertSelect methods"
jenkins-bot [Tue, 2 Oct 2018 15:12:05 +0000 (15:12 +0000)]
Merge "Add audience parameter to PoolWorkArticleView"
Aryeh Gregor [Mon, 6 Aug 2018 16:01:31 +0000 (19:01 +0300)]
Disallow overriding services that were set
Otherwise setService() calls (including indirect, like via
setContentLang() ) will be silently overridden. This bit me several
times already while working on tests. If someone actually wants to do
this, they should probably split their test in two, because it evidently
has two separate phases that they're testing (with/without services
set).
Depends-On: I9acb81c0de95eb5a6bed543d757ae62523ea6041
Change-Id: I8c60e37c179320e61684cbc11281c509e525e8fb
Brad Jorsch [Wed, 7 Mar 2018 16:40:56 +0000 (11:40 -0500)]
Migrate image descriptions from image_comment_temp
image_comment_temp was always intended to be temporary, until an
expensive schema change on Wikimedia Commons's image table could be
done. Now that that has been done, stop writing image_comment_temp and
add a migration script to copy existing data into img_description_id.
Ic8efeddc will remove the reads from image_comment_temp and drop the
image_comment_temp table.
Bug: T188132
Change-Id: Iab5f521577a415b2dc213b517ee8a0dca4fdd0aa
jenkins-bot [Tue, 2 Oct 2018 12:24:58 +0000 (12:24 +0000)]
Merge "Use pseudo elements to style changelist-separators on Contributions"
Gergő Tisza [Tue, 2 Oct 2018 01:33:28 +0000 (18:33 -0700)]
Add audience parameter to PoolWorkArticleView
The old behavior was that the audience was RAW if the revision object
parameter got passed in, otherwise PUBLIC. This was undocumented and
not used outside core; this patch gets rid of it in favor of an
explicit argument.
Bug: T205578
Change-Id: Ic7cdb38f658f6d85c48ff13c7f84c64a45c9b1ee
jenkins-bot [Tue, 2 Oct 2018 10:33:19 +0000 (10:33 +0000)]
Merge "Add type hint to invalidateImageDescriptions()"
Aaron Schulz [Tue, 2 Oct 2018 06:20:10 +0000 (23:20 -0700)]
Add type hint to invalidateImageDescriptions()
Change-Id: Ie6322f25c959f5de4bbccd8f47d40f112817d00b
jenkins-bot [Tue, 2 Oct 2018 05:16:07 +0000 (05:16 +0000)]
Merge "Replace WikiExporter streaming (unbuffered) mode with batched queries"
James D. Forrester [Tue, 2 Oct 2018 01:15:10 +0000 (18:15 -0700)]
Drop 'SpecialRecentChangesQuery' & 'SpecialWatchlistQuery' hooks, deprecated in 1.23
Depends-On: I9822bb2bc1bcc13eec7924208bf3819d3512ad26
Change-Id: I67c06bb99d9c9582a638f061f523661c821bca8d
jenkins-bot [Tue, 2 Oct 2018 01:06:20 +0000 (01:06 +0000)]
Merge "ApiOptions: fix resetting some preferences to default"
jenkins-bot [Tue, 2 Oct 2018 01:04:11 +0000 (01:04 +0000)]
Merge "Use varargs in global functions"
James D. Forrester [Tue, 18 Sep 2018 18:46:46 +0000 (11:46 -0700)]
Special:Preferences: Drop non-OOUI legacy form version
Change-Id: I65b89385c3ec28ef01b86dd933dae3801e503631
Stephane Bisson [Tue, 2 Oct 2018 00:34:55 +0000 (20:34 -0400)]
Remove unused function: isStructuredFilterUiEnabledByDefault
Follow up Id3799fefd21cd9bea0e089a5e12576ee9ea1085e
Bug: T196033
Change-Id: Ib2ad41be8648f7ff8b4a218fd66c328dee3924d9
James D. Forrester [Tue, 2 Oct 2018 00:32:31 +0000 (17:32 -0700)]
CategoryTagItemWidget: Drop backwards-compatibility "Capsule" name
Not used for months.
Change-Id: Ie85d2d0ef6ebc3e1e2502519a02b8fadd8d53b7a
jdlrobson [Tue, 18 Sep 2018 21:11:08 +0000 (14:11 -0700)]
Use pseudo elements to style changelist-separators on Contributions
Currently, these separators are unnecessarily hardcoded in HTML.
This is problematic, as it limits the extent to which skins such
as Minerva and Timeless can skin these pages.
If the pseudo selector is not available (e.g. legacy browsers)
this degrades nicely to whitespace and the page is still useable.
Right now, these changes are scoped to pages uses the ContribsPager
(used by Special:Contributions)
but we can adopt them in other pages once we have this approach set in
stone (CSS)
Bug: T205581
Change-Id: Ia2c485e6058ebf4282ed2f7eb7b046b2deb03f57
Gergő Tisza [Thu, 14 Jan 2016 23:53:56 +0000 (15:53 -0800)]
Hard-deprecate password handling in User
Add wfDeprecated for User::checkPassword(), User::setPassword(),
User::setInternalPassword() and User::checkTemporaryPassword().
With AuthManager mediating between the caller and a set of
authentication providers in a potentially multi-step process,
a password check or change now cannot always be expressed
with a single-step succed-or-fail process. Callers should use
AuthManager::beginAuthentication() with a PasswordAuthenticationRequest
for password checks, and AuthManager::changeAuthenticationData()
for a password change.
Bug: T91699
Change-Id: Ib0ae8f1ff10ae6c2655d529db8b3a32e0cb489b0